Skip to content

[release-branch.go1.26] eng: skip PR validation for docs-only changes - #2714

Open
Quim Muntal (qmuntal) wants to merge 2 commits into
microsoft/release-branch.go1.26from
dev/qmuntal/skip-docs-only-pr-validation-go1.26
Open

Quim Muntal (qmuntal) wants to merge 2 commits into
microsoft/release-branch.go1.26from
dev/qmuntal/skip-docs-only-pr-validation-go1.26

Conversation

@qmuntal

@qmuntal Quim Muntal (qmuntal) commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Backport of #2712.

Skip the PR pipelines for PRs that only change documentation (the root Markdown files, docs/, and eng/doc/), so automated docs-sync PRs into Go 1.26 no longer run the full innerloop. This branch has no pr.gen.yml, so the same path filters are applied to the hand-written innerloop and outerloop pipeline files.

The Go 1.26 GitHub Actions test workflow also now runs go test ./... in eng/_util. This preserves the generated crypto documentation reproducibility check when the Azure Pipelines build is skipped.

Validation:

  • Parsed both pipeline files as YAML and verified their pr: sections match main.
  • go test ./... in eng/_util passes, including cmd/updatecryptodocs.
  • The GitHub Actions workflow YAML parses successfully.

Add a path filter to the PR pipelines that excludes the root Markdown
files, docs, and eng/doc. When a PR only changes excluded paths, Azure
Pipelines skips the build and posts a neutral status to GitHub, which
GitHub accepts for the required microsoft-go check.

This avoids running the full innerloop for docs-only PRs, such as the
automated docs syncs into release branches.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner November 11, 2026 09:37
Copilot AI balanced review requested due to automatic review settings November 11, 2026 09:37
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The pipeline exclusion skips reproducibility validation for locally generated cryptography documentation without equivalent coverage in GitHub Actions.

1 open issue
What changed in this PR

Backports #2712 to the Go 1.26 release branch to skip Azure PR validation for documentation-only changes, including automated docs-sync PRs.

Changes:

  • Adds matching path exclusions to the innerloop and outerloop PR pipelines.
  • Preserves existing branch filters and validation for PRs that also change non-excluded files.
  • Applies the filters directly because this branch lacks pr.gen.yml.
File Description
eng/​pipeline/​pr-pipeline.yml Excludes selected root Markdown files, docs/, and eng/doc/ from innerloop PR triggers.
eng/​pipeline/​pr-outerloop-pipeline.yml Applies the same exclusions to outerloop PR triggers.

Review effort: Balanced

Comment thread eng/pipeline/pr-pipeline.yml Resolved
Run eng/_util tests in GitHub Actions on Go 1.26 PRs. This keeps the
crypto documentation reproducibility checks when Azure Pipelines skips
docs-only changes, without running the full innerloop.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@dagood Davis Goodin (dagood) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main PR not resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants